Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First level admin menu item looks weird if there is no custom template for it #2378

Closed
matiasmolleja opened this issue Sep 13, 2018 · 0 comments
Milestone

Comments

@matiasmolleja
Copy link
Member

matiasmolleja commented Sep 13, 2018

Repro steps:
Using Adminmenu.cs, add a first level menuItem without adding the corresponding custom "NavigationItemText" shape template as done here.

The layout for the menuItem looks ugly:
root-menu-no-icon

This issue is not relevant if people add menu items through code only, because it is expected that the developer provides a custom template.
But with the content tree module is going to be easy to add root items through UI and we should provide some better default.

I prepared a PR to fix that. Here is a gif:
root-menu-no-icon-fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants